Skip to content

feat: add openharmony platform preset certs folder #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richerfu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add openharmony platform preset certs folder #42

richerfu wants to merge 1 commit into from

Conversation

@richerfu
Copy link

@richerfu richerfu commented Nov 28, 2025 •
edited
Loading

follow #38 cc @djc

Also fix #29

@djc
Copy link
Member

djc commented Nov 28, 2025

Doesn't OpenHarmony have its own target_os?

@richerfu
Copy link
Author

richerfu commented Nov 28, 2025

Doesn't OpenHarmony have its own target_os?

No.. only target_env=ohos Should we use it?

@djc
Copy link
Member

djc commented Nov 28, 2025

Doesn't OpenHarmony have its own target_os?

No.. only target_env=ohos Should we use it?

I guess if that makes all the cfgs more complicated, it might not be worth it.

Please rebase on top of current main.

djc
djc reviewed Nov 28, 2025
View reviewed changes
@djc
Copy link
Member

djc commented Nov 28, 2025

(Please rebase and squash all your changes into a single commit.)

@djc djc changed the base branch from split to main November 28, 2025 09:32
djc
djc approved these changes Nov 28, 2025
View reviewed changes
Copy link
Member

@djc djc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me, let's see what other folks think.

@djc djc requested review from cpu and ctz November 28, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

@cpu cpu Awaiting requested review from cpu

@ctz ctz Awaiting requested review from ctz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richerfu @djc